Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
…th the correct --name parameter.
| c.argument('claims_matching_expression_value', options_list=['--cme-value', '-v'], help='A claims matching expression that is evaluated against incoming tokens for access token requests. Cannot be used with --subject.') | ||
| c.argument('claims_matching_expression_version', options_list=['--cme-version', '-e'], help='Version of the claims matching expression language. Required when using --cme-value.') |
There was a problem hiding this comment.
The best practice is to use full names, such as --claims-matching-expression-value, --claims-matching-expression-version. Using --cme-value and --cme-version can be confusing. -v and -e are worse.
| with self.argument_context('identity federated-credential', min_api='2022-01-31-preview') as c: | ||
| c.argument('federated_credential_name', options_list=('--name', '-n'), help='The name of the federated identity credential resource.') | ||
| with self.argument_context('identity federated-credential', min_api='2025-01-31-preview') as c: | ||
| c.argument('federated_credential_name', options_list=['--fc-name', '-f'], help='The name of the federated identity credential resource.') |
There was a problem hiding this comment.
Renaming federated_credential_name from --name/-n to --fc-name/-f is incorrect as --name argument should match the command noun/subject - federated-credential. This is also a breaking change and not allowed.
| - name: Create a federated identity credential using subject identifier | ||
| text: | | ||
| az identity federated-credential create --name myFicName --identity-name myIdentityName --resource-group myResourceGroup --issuer myIssuer --subject mySubject --audiences myAudiences | ||
| az identity federated-credential create --fc-name myFedCredential --name myIdentity --resource-group myResourceGroup --issuer 'https://aks.azure.com/issuerGUID' --subject 'system:serviceaccount:ns:svcaccount' --audiences 'api://AzureADTokenExchange' |
There was a problem hiding this comment.
Changing --identity-name to --name is incorrect and not allowed.
5 participants
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.